lkml.org 
[lkml]   [2010]   [Apr]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH V2 0/6][RFC] futex: FUTEX_LOCK with optional adaptive spinning
* Darren Hart (dvhltc@us.ibm.com) wrote:
> Avi Kivity wrote:
>
>>>> An interesting (but perhaps difficult to achieve) optimization
>>>> would be to spin in userspace.
>>>
>>> I couldn't think of a lightweight way to determine when the owner has
>>> been scheduled out in userspace. Kernel assistance is required. You
>>> could do this on the schedule() side of things, but I figured I'd get
>>> some strong pushback if I tried to add a hook into descheduling that
>>> flipped a bit in the futex value stating the owner was about to
>>> deschedule(). Still, that might be something to explore.
>>
>> In the futex value it's hopeless (since a thread can hold many locks),
>
> It can, but there is a futex value per lock. If the task_struct had a
> list of held futex locks (as it does for pi futex locks) the
> deschedule() path could walk that and mark the FUTEX_OWNER_SLEEPING bit.

You also have a notification scheme (preempt_notifiers will fire on
schedule out). However, you'd have to register the notifiers from a
non-current context (i.e. on slow path acquire reaching out to lock owner
and registering notifier on lock owner's behalf, which would kind of
defeat the point AFAICT).

thanks,
-chris


\
 
 \ /
  Last update: 2010-04-06 01:33    [W:0.088 / U:1.332 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site