Messages in this thread | | | Date | Sun, 4 Apr 2010 21:05:12 +0200 | From | Ingo Molnar <> | Subject | Re: [PATCH 0/2] perf newt: Zoom operations |
| |
* Arnaldo Carvalho de Melo <acme@infradead.org> wrote:
> Em Sun, Apr 04, 2010 at 11:58:27AM +0200, Ingo Molnar escreveu: > > * Arnaldo Carvalho de Melo <acme@infradead.org> wrote: > > > Arnaldo Carvalho de Melo (2): > > > perf newt: Add a "Zoom into foo.so DSO" and reverse operations > > > perf TUI: Add a "Zoom into COMM(PID) thread" and reverse operations > > > > Pulled, thanks Arnaldo! > > > > There's still a few basic usability glitches that i've noticed: > > > > - it's not clear how to zoom out, once zoomed in > > I'll use the title line to store the name of the DSO and Thread and the help > line to state that to zoom out, press -> + zoom out, and I think that it is > a good idea to use 'd' and 'D' to zoom in/out of DSOs and 't' and 'T' to > zoom in/out of DSOs.
Cool, a help line will do the trick i'm sure. The only problem situation is when there is zero information about how to proceed - some people exit and dont ever come back in that case :-)
> > - there's no help screen and no help line for people to see what can be > > done on a given screen. While it's good that the intuitive things work > > by default (arrow keys, escape, enter, etc.), there should also be additional > > visual information about what can be done. > > F1 and textboxes with a short description of what can be done given for the > first time or till the user presses "Suppress these info boxes" will be > added.
Maybe we need 'h' and '?' in addition of F1, as F1 is often already mapped and caught by the terminal (it is so with gnome-terminal).
> > > - i think double escape should exit, right now it stays at the 'are you sure' > > screen > > Here I thought that something had to be done to avoid that accidentally > pressing ESC two times or having "Yes" as default option, trowing away > possibly a long processed session, what do others think about it?
Yeah, i think you are right.
> I think that ESC + "Yes" as a default may be ok, as two keys need to be > pressed (ESC + Enter), enough warning/confirmation, I gues, right?
Ok, that would work!
Thanks,
Ingo
| |