Messages in this thread Patch in this message | | | From | Hitoshi Mitake <> | Subject | [PATCH] Swap including order of util.h and string.h of util/string.c | Date | Sun, 4 Apr 2010 17:13:18 +0900 |
| |
Current util/string.c includes headers in this order: string.h, util.h But this causes build error because __USE_GNU definition is needed for strndup() definition like this, % make -j touch .perf.dev.null CC util/string.o cc1: warnings being treated as errors util/string.c: In function âargv_splitâ: util/string.c:171: error: implicit declaration of function âstrndupâ util/string.c:171: error: incompatible implicit declaration of built-in function âstrndupâ
So this patch swaps order of including headers. util.h defines _GNU_SOURCE, and /usr/include/features.h defines __USE_GNU as 1 if _GNU_SOURCE is defined.
Signed-off-by: Hitoshi Mitake <mitake@dcl.info.waseda.ac.jp> Cc: Peter Zijlstra <a.p.zijlstra@chello.nl> Cc: Paul Mackerras <paulus@samba.org> Cc: Frederic Weisbecker <fweisbec@gmail.com> Cc: Arnaldo Carvalho de Melo <acme@redhat.com> --- tools/perf/util/string.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/tools/perf/util/string.c b/tools/perf/util/string.c index d438924..0409fc7 100644 --- a/tools/perf/util/string.c +++ b/tools/perf/util/string.c @@ -1,5 +1,5 @@ -#include "string.h" #include "util.h" +#include "string.h" #define K 1024LL /* -- 1.6.5.2 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |