lkml.org 
[lkml]   [2010]   [Apr]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 04/14] vc: Locking clean up
Date
On Thursday 01 April 2010 18:04:59 Alan Cox wrote:
> @@ -282,7 +282,12 @@ static inline unsigned short *screenpos(struct vc_data *vc, int offset, int view
>
> static inline void scrolldelta(int lines)
> {
> + lock_kernel();
> + /* FIXME */
> + /* scrolldelta needs some kind of consistency lock, but the BKL was
> + and still is not protecting versus the scheduled back end */
> scrollback_delta += lines;
> + unlock_kernel();
> schedule_console_callback();
> }
>

This one triggered a might_sleep() warning in _lock_kernel(), because
it's called from the keyboard interrupt.

Arnd


\
 
 \ /
  Last update: 2010-04-30 22:33    [W:0.267 / U:0.108 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site