Messages in this thread | | | Date | Thu, 29 Apr 2010 10:52:45 -0500 | Subject | Re: 2.6.33.3-rt16 Oops caused by umount | From | Xianghua Xiao <> |
| |
On Thu, Apr 29, 2010 at 10:15 AM, Phil Carmody <ext-phil.2.carmody@nokia.com> wrote: > On 28/04/10 19:54 +0200, ext Xianghua Xiao wrote: >> On Wed, Apr 28, 2010 at 11:34 AM, Thomas Gleixner <tglx@linutronix.de> wrote: > ... >> Thomas, >> I patched it and re-run it however did not find any condition from >> your patch had a hit. >> In your patch I changed : >> >> if (!file->f_path) { >> to >> if(!(&(file->f_path))){ >> Otherwise it won't compile as f_path is a not a pointer. > > That check is completely bogus. The address of _anything_ (whose address > can be taken) is _always_ non-null. > > Phil >
Thomas,
I confirm that 2.6.33.3-rt15 worked fine, reboot/umount will not oops.
Thanks, Xianghua
| |