Messages in this thread Patch in this message | | | From | Kay Sievers <> | Date | Wed, 28 Apr 2010 10:23:05 +0200 | Subject | Re: request_firmware API exhaust memory |
| |
On Tue, Apr 27, 2010 at 15:34, Kay Sievers <kay.sievers@vrfy.org> wrote: > On Tue, Apr 27, 2010 at 14:43, David Woodhouse <dwmw2@infradead.org> wrote: >> This untested patch attempts to put the page array into the 'struct >> firmware' so that we can free it from release_firmware(). > > Looks good. Seems to work without problems and without leaking memory. > > Misses only the member in the struct firmware though. :)
Thomas, any chance to test David's patch, if that solves the issues you've seen?
Just add the missing line:
--- a/include/linux/firmware.h +++ b/include/linux/firmware.h @@ -12,6 +12,7 @@ struct firmware { size_t size; const u8 *data; + struct page **pages; };
Thanks, Kay
| |