lkml.org 
[lkml]   [2010]   [Apr]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] staging: winbond: localpara.h whitespace and indentation fixes.
On Fri, Mar 19, 2010 at 12:00:59AM +0100, Lars Lindley wrote:
> On 2010-03-18 17:22, Pekka Enberg wrote:
> > Lars Lindley wrote:
> >> +/* refer Bitmap2RateValue table */
> >> +#define LOCAL_ALL_SUPPORTED_RATES_BITMAP 0x130c1a66 /*
> >> + * the bitmap value
> >> + * of all the H/W
> >> + * supported rates:
> >> + * 1, 2, 5.5, 11,
> >> + * 6, 9, 12, 18,
> >> + * 24, 36, 48, 54
> >> + */
> >
> > The comments look funny. You might want to move them above the #defines.
> >
> >> + u8 region; /* real region setting of the device */
> >> + u8 Reserved_1[2];
> >> +
> >> +/* power-save variables */
> >
> > I think this wants to be moved one indentation level to the right.
> >
> Ok here's a patch that applies over the old one to fix this..
> Hope it looks all right.. :)

Can you merge the two of them together and resend?

thanks,

greg k-h


\
 
 \ /
  Last update: 2010-04-29 01:11    [W:0.118 / U:0.028 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site