lkml.org 
[lkml]   [2010]   [Apr]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 20/30] via: Rationalize vt1636 detection
    Date
    The code was ugly and didn't check whether i2c operations were succeeding;
    make it a little better.

    Signed-off-by: Jonathan Corbet <corbet@lwn.net>
    ---
    drivers/video/via/vt1636.c | 20 +++++++-------------
    1 files changed, 7 insertions(+), 13 deletions(-)

    diff --git a/drivers/video/via/vt1636.c b/drivers/video/via/vt1636.c
    index e9f3661..e5f8024 100644
    --- a/drivers/video/via/vt1636.c
    +++ b/drivers/video/via/vt1636.c
    @@ -167,26 +167,20 @@ bool viafb_lvds_identify_vt1636(u8 i2c_adapter)

    /* Sense VT1636 LVDS Transmiter */
    viaparinfo->chip_info->lvds_chip_info.lvds_chip_slave_addr =
    - VT1636_LVDS_I2C_ADDR;
    + VT1636_LVDS_I2C_ADDR;

    /* Check vendor ID first: */
    - viafb_i2c_readbyte(i2c_adapter,
    - (u8) viaparinfo->chip_info->lvds_chip_info.lvds_chip_slave_addr,
    - 0x00, &Buffer[0]);
    - viafb_i2c_readbyte(i2c_adapter,
    - (u8) viaparinfo->chip_info->lvds_chip_info.lvds_chip_slave_addr,
    - 0x01, &Buffer[1]);
    + if (viafb_i2c_readbyte(i2c_adapter, VT1636_LVDS_I2C_ADDR,
    + 0x00, &Buffer[0]))
    + return false;
    + viafb_i2c_readbyte(i2c_adapter, VT1636_LVDS_I2C_ADDR, 0x01, &Buffer[1]);

    if (!((Buffer[0] == 0x06) && (Buffer[1] == 0x11)))
    return false;

    /* Check Chip ID: */
    - viafb_i2c_readbyte(i2c_adapter,
    - (u8) viaparinfo->chip_info->lvds_chip_info.lvds_chip_slave_addr,
    - 0x02, &Buffer[0]);
    - viafb_i2c_readbyte(i2c_adapter,
    - (u8) viaparinfo->chip_info->lvds_chip_info.lvds_chip_slave_addr,
    - 0x03, &Buffer[1]);
    + viafb_i2c_readbyte(i2c_adapter, VT1636_LVDS_I2C_ADDR, 0x02, &Buffer[0]);
    + viafb_i2c_readbyte(i2c_adapter, VT1636_LVDS_I2C_ADDR, 0x03, &Buffer[1]);
    if ((Buffer[0] == 0x45) && (Buffer[1] == 0x33)) {
    viaparinfo->chip_info->lvds_chip_info.lvds_chip_name =
    VT1636_LVDS;
    --
    1.7.0.1


    \
     
     \ /
      Last update: 2010-04-29 00:25    [W:0.022 / U:2.316 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site