Messages in this thread | | | Date | Wed, 28 Apr 2010 23:24:27 +0200 | From | Michal Marek <> | Subject | USB_SERIAL_KEYSPAN_* dependency on FIRMWARE_IN_KERNEL |
| |
Hi David,
I recently disabled CONFIG_FIRMWARE_IN_KERNEL in the default openSUSE kernels (as no built-in driver needs firmware and the initrd takes care of the modules), but this disabled all the CONFIG_USB_SERIAL_KEYSPAN_* options, because there is
config USB_SERIAL_KEYSPAN_MPR bool "USB Keyspan MPR Firmware" depends on USB_SERIAL_KEYSPAN && FIRMWARE_IN_KERNEL etc
in drivers/usb/serial/Kconfig, added in 2971c57 by you. Is there a reason for this dependency or shouldn't this rather depend on FW_LOADER? On a related note, firmware/Makefile has
ifdef CONFIG_FIRMWARE_IN_KERNEL fw-shipped-$(CONFIG_USB_SERIAL_KEYSPAN_MPR) += keyspan/mpr.fw ... else fw-shipped- += keyspan/mpr.fw ... endif
which just duplicates the dependency (if CONFIG_FIRMWARE_IN_KERNEL is not set, the CONFIG_USB_SERIAL_KEYSPAN_* options won't be set either). Note that I do not have the hardware, so maybe I'm missing something obvious...
thanks, Michal
| |