lkml.org 
[lkml]   [2010]   [Apr]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH 01/10][RFC] tracing: Create class struct for events
    From
    Date
    On Wed, 2010-04-28 at 16:22 -0400, Mathieu Desnoyers wrote:

    > > #undef DEFINE_EVENT
    > > #define DEFINE_EVENT(template, name, proto, args) \
    > > static struct ftrace_event_call \
    > > @@ -430,22 +433,6 @@ perf_trace_disable_##name(struct ftrace_event_call *unused) \
    > > *
    > > * Override the macros in <trace/trace_events.h> to include the following:
    > > *
    > > - * static void ftrace_event_<call>(proto)
    > > - * {
    > > - * event_trace_printk(_RET_IP_, "<call>: " <fmt>);
    > > - * }
    > > - *
    > > - * static int ftrace_reg_event_<call>(struct ftrace_event_call *unused)
    > > - * {
    > > - * return register_trace_<call>(ftrace_event_<call>);
    > > - * }
    > > - *
    > > - * static void ftrace_unreg_event_<call>(struct ftrace_event_call *unused)
    > > - * {
    > > - * unregister_trace_<call>(ftrace_event_<call>);
    > > - * }
    > > - *
    > > - *
    > > * For those macros defined with TRACE_EVENT:
    > > *
    > > * static struct ftrace_event_call event_<call>;
    >
    > So.. just wondering, why are you removing these comments ? What's
    > replacing them ?
    >
    > Maybe you meant to remove this in a following patch ?

    I found a lot of stale comments, these were added with cut and paste
    before, and I just removed them here.

    -- Steve




    \
     
     \ /
      Last update: 2010-04-28 22:41    [W:3.724 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site