lkml.org 
[lkml]   [2010]   [Apr]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 01/10][RFC] tracing: Create class struct for events
    * Steven Rostedt (rostedt@goodmis.org) wrote:
    > From: Steven Rostedt <srostedt@redhat.com>
    >
    > This patch creates a ftrace_event_class struct that event structs point to.
    > This class struct will be made to hold information to modify the
    > events. Currently the class struct only holds the events system name.
    >
    > This patch slightly increases the size of the text as well as decreases
    > the data size. The overall change is still a slight increase, but
    > this change lays the ground work of other changes to make the footprint
    > of tracepoints smaller.
    >
    > With 82 standard tracepoints, and 616 system call tracepoints:
    >
    > text data bss dec hex filename
    > 5788186 1337252 9351592 16477030 fb6b66 vmlinux.orig
    > 5792282 1333796 9351592 16477670 fb6de6 vmlinux.class
    >
    > Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
    > ---
    > include/linux/ftrace_event.h | 6 +++++-
    > include/linux/syscalls.h | 6 ++++--
    > include/trace/ftrace.h | 36 +++++++++++++++---------------------
    > kernel/trace/trace_events.c | 20 ++++++++++----------
    > kernel/trace/trace_events_filter.c | 6 +++---
    > kernel/trace/trace_export.c | 6 +++++-
    > kernel/trace/trace_kprobe.c | 12 ++++++------
    > kernel/trace/trace_syscalls.c | 4 ++++
    > 8 files changed, 52 insertions(+), 44 deletions(-)
    >
    [...]
    > diff --git a/include/trace/ftrace.h b/include/trace/ftrace.h
    > index 75dd778..0921a8f 100644
    > --- a/include/trace/ftrace.h
    > +++ b/include/trace/ftrace.h
    > @@ -62,7 +62,10 @@
    > struct trace_entry ent; \
    > tstruct \
    > char __data[0]; \
    > - };
    > + }; \
    > + \
    > + static struct ftrace_event_class event_class_##name;
    > +
    > #undef DEFINE_EVENT
    > #define DEFINE_EVENT(template, name, proto, args) \
    > static struct ftrace_event_call \
    > @@ -430,22 +433,6 @@ perf_trace_disable_##name(struct ftrace_event_call *unused) \
    > *
    > * Override the macros in <trace/trace_events.h> to include the following:
    > *
    > - * static void ftrace_event_<call>(proto)
    > - * {
    > - * event_trace_printk(_RET_IP_, "<call>: " <fmt>);
    > - * }
    > - *
    > - * static int ftrace_reg_event_<call>(struct ftrace_event_call *unused)
    > - * {
    > - * return register_trace_<call>(ftrace_event_<call>);
    > - * }
    > - *
    > - * static void ftrace_unreg_event_<call>(struct ftrace_event_call *unused)
    > - * {
    > - * unregister_trace_<call>(ftrace_event_<call>);
    > - * }
    > - *
    > - *
    > * For those macros defined with TRACE_EVENT:
    > *
    > * static struct ftrace_event_call event_<call>;

    So.. just wondering, why are you removing these comments ? What's
    replacing them ?

    Maybe you meant to remove this in a following patch ?

    Thanks,

    Mathieu


    --
    Mathieu Desnoyers
    Operating System Efficiency R&D Consultant
    EfficiOS Inc.
    http://www.efficios.com


    \
     
     \ /
      Last update: 2010-04-28 22:25    [W:0.032 / U:91.936 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site