Messages in this thread | | | Date | Wed, 28 Apr 2010 10:22:31 -0700 | From | Greg KH <> | Subject | Re: [PATCH 1/3] drivers/staging/dt3155: Integrate 3 badly styled files into 1 clean file |
| |
On Wed, Apr 28, 2010 at 09:33:25AM -0700, Joe Perches wrote: > On Wed, 2010-04-28 at 12:12 -0400, Valdis.Kletnieks@vt.edu wrote: > > On Tue, 27 Apr 2010 23:00:30 PDT, Joe Perches said: > > > On Tue, 2010-04-27 at 22:52 -0700, Greg KH wrote: > > > > > I seem to be learning that you little taste. > > > > -ENOPARSE > > > > > > Choosing competing patches based on date received > > > order not quality is poor taste. > > > > So you're saying when Greg gets a somewhat ugly but passable patch 2 weeks ago, > > he's supposed to *just know* that you'll be submitting a possibly better one 2 > > weeks later and wait for it to show up? > > No, I'm saying that when Greg gets multiple > patches for the same module and doesn't act on > any of them for several weeks, (in this case > one 6 weeks ago, and two others 4 weeks ago) > he should select the better patches, not just > apply the first one in chronological order.
In this case, I _did_ select the best patches. Your "do it all in one patch" was not acceptable, especially as others sent small, do-one-thing, type patches.
I'm sorry you don't agree with this decision, but that was my call.
thanks,
greg k-h
| |