lkml.org 
[lkml]   [2010]   [Apr]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 1/3] drivers/staging/dt3155: Integrate 3 badly styled files into 1 clean file
From
Date
On Tue, 2010-04-27 at 16:02 -0700, Greg KH wrote:
> On Mon, Mar 29, 2010 at 12:34:28AM -0700, Joe Perches wrote:
> > Make variables static where appropriate
> > Rename dt3155_<foo_with_long_names> variables to dt_<foo_tla>
> > to reduce code length and make more lines fit well in 80 chars
> > Remove now unnecessary .h files
> > Change indent to use tabs
> > Remove unused functions
> > Used bool more often
> > Checkpatch clean
>
> This is too much in one patch, sorry.

You should be more consistent.

http://www.tuxradar.com/content/newbies-guide-hacking-linux-kernel
Greg even said, "submit one big patch if you want"


> It also doesn't apply due to
> other changes in these files (that you then remove in patch 3) from
> other developers.

No, it doesn't apply because you chose to apply other patches
before this one.




\
 
 \ /
  Last update: 2010-04-28 07:33    [W:0.095 / U:0.028 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site