lkml.org 
[lkml]   [2010]   [Apr]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/2 v2] MMC:Add support MMCIF for SuperH
On Wed, 28 Apr 2010 14:06:08 +0900 Yusuke Goda <yusuke.goda.sx@renesas.com> wrote:

> + time = wait_event_interruptible_timeout(host->intr_wait,
> + host->wait_int == 1 ||
> + host->sd_error == 1, host->timeout);
> + if (host->wait_int != 1 && (time == 0 || host->sd_error != 0))
> + return sh_mmcif_error_manage(host);

wait_event_interruptible_timeout() will return early with -ERESTARTSYS
if the calling process gets signalled (eg, ^C was hit).

The driver uses wait_event_interruptible_timeout() rather a lot and the
two sites I looked at seem to handle the signal_pending() case
correctly.

But incorrectly handling signals with interruptible waits is a
frequently-occurring error in drivers. Did you deliberately cater for
this case, and have you runtime tested it?



\
 
 \ /
  Last update: 2010-04-28 07:21    [W:0.040 / U:0.012 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site