Messages in this thread | | | Date | Tue, 27 Apr 2010 16:02:28 -0700 | From | Greg KH <> | Subject | Re: [PATCH 1/3] drivers/staging/dt3155: Integrate 3 badly styled files into 1 clean file |
| |
On Mon, Mar 29, 2010 at 12:34:28AM -0700, Joe Perches wrote: > Make variables static where appropriate > Rename dt3155_<foo_with_long_names> variables to dt_<foo_tla> > to reduce code length and make more lines fit well in 80 chars > Remove now unnecessary .h files > Change indent to use tabs > Remove unused functions > Used bool more often > Checkpatch clean
This is too much in one patch, sorry. It also doesn't apply due to other changes in these files (that you then remove in patch 3) from other developers.
thanks,
greg k-h
| |