Messages in this thread | | | Date | Tue, 27 Apr 2010 14:00:29 -0700 | From | Greg KH <> | Subject | Re: [PATCH 2/2] Staging:dt3155: fix coding style issue in dt3155_drv.c This is a patch to the dt3155_drv.c file that fixes up a coding style warning and errors found by the checkpatch.pl tool; |
| |
On Sat, Mar 13, 2010 at 01:34:37PM +0500, Gorskin Ilya wrote: > @@ -183,241 +183,215 @@ static inline void dt3155_isr( int irq, void *dev_id, struct pt_regs *regs ) > u32 buffer_addr; > > /* find out who issued the interrupt */ > - for ( index = 0; index < ndevices; index++ ) { > - if( dev_id == (void*) &dt3155_status[ index ]) > - { > - minor = index; > + for (index = 0; index < ndevices; index++) { > + if (dev_id == (void *) &dt3155_status[index]) { > + minor = index;
This fixes up the {} usage, but not the tabs/spaces issues, so it is still incorrect. Can you fix that up at the same time here?
thanks,
greg k-h
| |