Messages in this thread | | | Date | Tue, 27 Apr 2010 20:07:56 +0200 | From | Frederic Weisbecker <> | Subject | Re: [PATCH] lockdep: Fix redundant_hardirqs_on incremented with irqs enabled |
| |
On Tue, Apr 27, 2010 at 05:32:27PM +1000, Stephen Rothwell wrote: > Hi Frederic, > > On Thu, 15 Apr 2010 15:37:50 +0200 Frederic Weisbecker <fweisbec@gmail.com> wrote: > > > > When a path restore the flags while irqs are already enabled, we > > update the per cpu var redundant_hardirqs_on in a racy fashion > > and debug_atomic_inc() warns about this situation. > > > > In this particular case, we need to explictly disable the irqs before > > updating this stat var in order to update it safely. > > > > Reported-by: Stephen Rothwell <sfr@canb.auug.org.au> > > Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com> > > Cc: Peter Zijlstra <peterz@infradead.org> > > Cc: David Miller <davem@davemloft.net> > > Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org> > > --- > > kernel/lockdep.c | 4 ++++ > > 1 files changed, 4 insertions(+), 0 deletions(-) > > Ping? Any movement on this?
Ingo, if you have no problems with these two patches, could you please apply them?
Thanks.
| |