lkml.org 
[lkml]   [2010]   [Apr]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 2/9] perf: Fix initialization bug in parse_single_tracepoint_event()
    Date
    From: Stephane Eranian <eranian@google.com>

    The parse_single_tracepoint_event() was setting some attributes
    before it validated the event was indeed a tracepoint event. This
    caused problems with other initialization routines like in the
    builtin-top.c module whereby sample_period is not set if not 0.

    Signed-off-by: Stephane Eranian <eranian@google.com>
    Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
    Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
    Cc: Paul Mackerras <paulus@samba.org>
    Cc: Ingo Molnar <mingo@elte.hu>
    LKML-Reference: <4bcf232b.698fd80a.6fbe.ffffb737@mx.google.com>
    Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>
    ---
    tools/perf/util/parse-events.c | 13 +++++++------
    1 files changed, 7 insertions(+), 6 deletions(-)

    diff --git a/tools/perf/util/parse-events.c b/tools/perf/util/parse-events.c
    index 3b4ec67..600d327 100644
    --- a/tools/perf/util/parse-events.c
    +++ b/tools/perf/util/parse-events.c
    @@ -418,12 +418,6 @@ parse_single_tracepoint_event(char *sys_name,
    u64 id;
    int fd;

    - attr->sample_type |= PERF_SAMPLE_RAW;
    - attr->sample_type |= PERF_SAMPLE_TIME;
    - attr->sample_type |= PERF_SAMPLE_CPU;
    -
    - attr->sample_period = 1;
    -
    snprintf(evt_path, MAXPATHLEN, "%s/%s/%s/id", debugfs_path,
    sys_name, evt_name);

    @@ -442,6 +436,13 @@ parse_single_tracepoint_event(char *sys_name,
    attr->type = PERF_TYPE_TRACEPOINT;
    *strp = evt_name + evt_length;

    + attr->sample_type |= PERF_SAMPLE_RAW;
    + attr->sample_type |= PERF_SAMPLE_TIME;
    + attr->sample_type |= PERF_SAMPLE_CPU;
    +
    + attr->sample_period = 1;
    +
    +
    return EVT_HANDLED;
    }

    --
    1.6.2.3


    \
     
     \ /
      Last update: 2010-04-24 04:09    [W:0.033 / U:0.548 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site