lkml.org 
[lkml]   [2010]   [Apr]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[114/139] e1000e: stop cleaning when we reach tx_ring->next_to_use
    2.6.33-stable review patch.  If anyone has any objections, please let us know.

    ------------------

    From: Terry Loftin <terry.loftin@hp.com>

    commit dac876193cd79ced36d0462749ea47c05844fb49 upstream.

    Tx ring buffers after tx_ring->next_to_use are volatile and could
    change, possibly causing a crash. Stop cleaning when we hit
    tx_ring->next_to_use.

    Signed-off-by: Terry Loftin <terry.loftin@hp.com>
    Acked-by: Bruce Allan <bruce.w.allan@intel.com>
    Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Cc: Matthew Burgess <matthew@linuxfromscratch.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

    ---
    drivers/net/e1000e/netdev.c | 2 ++
    1 file changed, 2 insertions(+)

    --- a/drivers/net/e1000e/netdev.c
    +++ b/drivers/net/e1000e/netdev.c
    @@ -660,6 +660,8 @@ static bool e1000_clean_tx_irq(struct e1
    i = 0;
    }

    + if (i == tx_ring->next_to_use)
    + break;
    eop = tx_ring->buffer_info[i].next_to_watch;
    eop_desc = E1000_TX_DESC(*tx_ring, eop);
    }



    \
     
     \ /
      Last update: 2010-04-22 22:15    [W:4.409 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site