lkml.org 
[lkml]   [2010]   [Apr]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] [MTD] Fix JFFS2 sync silent failure


On Thu, 22 Apr 2010, Jörn Engel wrote:
>
> I think this is bad enough that you should be involved. 32a88aa1 broke
> a number of filesystems in a way that sync() would return 0 without
> doing any work. Even politicians are better at keeping the promises.
>
> This is caused by the two-liner in __sync_filesystem:
> if (!sb->s_bdi)
> return 0;
> s_bdi is set implicitly for all filesystems using set_bdev_super(), so
> most block device based filesystems are safe. There are, however, a
> number of odd-balls around:

Umm. Why not just remove the two-liner? It was incorrect. The comment says
"this should be safe", and if it wasn't, then the commit that caused this
all was total crap to begin with.

Why even discuss any other measures?

Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2010-04-22 16:29    [W:2.384 / U:0.024 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site