[lkml]   [2010]   [Apr]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: What's the staging review and acceptance process?
On Wed, Apr 21, 2010 at 01:32:47PM -0700, Joe Perches wrote:
> Hi Greg.
> Sice your fosdem talk and tuxradar article came out there
> have been many patches against staging by new contributors
> (I did some too) that seem to get no feedback or get dropped
> without comment. Because many of these patches are first
> attempts, probably most of them should not be applied in the
> first submitted form. I comment on some every once in awhile,
> but the number of patches appear to go unnoticed or untracked
> seems quite high.

I have around 600 still left to go through. It was an unfortunate set
of timing, the talk, article, and then I up and moved a few hundred
miles and decided to attend a few conferences, as well as maintaining 4
stable trees at the same time. That caused the huge backlog staring at
me right now.

> Do you have enough bandwidth to keep these new contributors
> engaged? Anything I can do to help?

Your reviews like you have been doing, when you see something obviously
wrong, is great. I just went through 100 patches, and only 40 of them
were "valid" and able to be applied, so it is a high rejection rate
which requires a lot of attention to be paid to them.

> What is your current review/notify/accept/reject workflow?

Like it's always been:
- patch comes in
- I get around to reviewing it
- if valid, I apply and you get an email
- if invalid, I reject and say why in email

> Perhaps a patchwork queue for staging might help track these
> patches and with more feedback or reviewers, get them in
> shape to be applied.

patchwork doesn't work well for my patch flow, but maybe that is because
I haven't spent enough time with it. Right now I have all the patches,
it's just a matter of getting through them.


greg k-h

 \ /
  Last update: 2010-04-22 05:47    [W:0.114 / U:0.372 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site