lkml.org 
[lkml]   [2010]   [Apr]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 1/2] input: Add support of Synaptics Clickpad device
    At Tue, 20 Apr 2010 22:44:55 -0700,
    Dmitry Torokhov wrote:
    >
    > On Mon, Apr 19, 2010 at 12:29:49PM +0200, Takashi Iwai wrote:
    > > Hi Dmitry,
    > >
    > > At Mon, 19 Apr 2010 01:32:22 -0700,
    > > Dmitry Torokhov wrote:
    > > >
    > > > Hi Takashi,
    > > >
    > > > On Wed, Apr 14, 2010 at 05:10:22PM +0200, Takashi Iwai wrote:
    > > > > Add the detection of Synaptics Clickpad device.
    > > > > The device can be detected a new query command 0x0c. The clickpad
    > > > > flags are in cap[0]:4 and cap[1]:0 bits. But, the driver checks
    > > > > first the product id bits in the ext capabilities to be sure, so
    > > > > that it skips the new check on older devices.
    > > > >
    > > >
    > > > Instead of looking at the product id, can we check the number of
    > > > supported extended capabilities queries and act accordingly, like the
    > > > patch below?
    > >
    > > Yes, it worked. (Though, I've tested only new machines.)
    > >
    >
    >
    > Seems to be working on older (at least one ;) ) as well.
    >
    > >
    > > > @@ -162,6 +163,16 @@ static int synaptics_capability(struct psmouse *psmouse)
    > > > priv->ext_cap &= 0xff0fff;
    > > > }
    > > > }
    > > > +
    > > > + if (SYN_EXT_CAP_REQUESTS(priv->capabilities) >= 4) {
    > > > + if (synaptics_send_cmd(psmouse, SYN_QUE_EXT_CAPAB_0C, cap)) {
    > > > + printk(KERN_ERR "Synaptics claims to have extended capability 0x0c,"
    > > > + " but I'm not able to read it.");
    > >
    > > Here missing a newline, BTW.
    > >
    >
    > Fixed. Thank you for testing. I have that patch in 'for-linus' for .34.
    > Please push your synaptics X changes upstream as well.

    Thanks. It was already submitted.
    I'm going to repost the revised X patch later.


    Takashi


    \
     
     \ /
      Last update: 2010-04-21 08:35    [W:0.024 / U:30.556 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site