lkml.org 
[lkml]   [2010]   [Apr]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/2] ibft: Update iBFT handling for v1.03 of the spec.
On Fri,  9 Apr 2010 14:21:27 +0000
Konrad Rzeszutek Wilk <konrad@kernel.org> wrote:

> From: Peter Jones <pjones@redhat.com>
>
> - Use struct acpi_table_ibft instead of struct ibft_table_header
> - Don't do reserve_ibft_region() on UEFI machines (section 1.4.3.1)
> - If ibft_addr isn't initialized when ibft_init() is called, check for
> ACPI-based tables.
>
> Author: Peter Jones <pjones@redhat.com>
> Signed-off-by: Konrad Rzeszutek Wilk <konrad@kernel.org>
> Reviewed-by: Mike Christie <michaelc@cs.wisc.edu>

This should have Peter's Signed-off-by:, please.

>
> ...
>
> +#ifdef CONFIG_ACPI
> +static int __init acpi_find_ibft(struct acpi_table_header *header)
> +{
> + ibft_addr = (struct acpi_table_ibft *)header;

container_of() would be better here. And maybe elsewhere, too.

> + return 0;
> +}
> +#endif /* CONFIG_ACPI */



\
 
 \ /
  Last update: 2010-04-21 23:29    [W:0.101 / U:1.504 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site