Messages in this thread | | | Date | Wed, 21 Apr 2010 19:46:15 +0200 | From | Andrea Arcangeli <> | Subject | Re: [patch] ksm: check for ERR_PTR from follow_page() |
| |
On Wed, Apr 21, 2010 at 11:24:24AM -0400, Rik van Riel wrote: > On 04/21/2010 06:27 AM, Dan Carpenter wrote: > > The follow_page() function can potentially return -EFAULT so I added > > checks for this. > > > > Also I silenced an uninitialized variable warning on my version of gcc > > (version 4.3.2). > > > > Signed-off-by: Dan Carpenter<error27@gmail.com> > > Acked-by: Rik van Riel <riel@redhat.com>
while (!(page = follow_page(vma, start, foll_flags))) {
gup only checks for null, so when exactly is follow_page going to return -EFAULT? It's not immediately clear.
| |