Messages in this thread | | | Subject | Re: [RFC] perf_events: support for uncore a.k.a. nest units | From | Peter Zijlstra <> | Date | Wed, 21 Apr 2010 16:22:35 +0200 |
| |
On Wed, 2010-04-21 at 22:12 +0000, Lin Ming wrote: > + ret = pmu->commit_txn(pmu); > + if (!ret) { > + pmu->stop_txn(pmu); > + return 0; > + } > > group_error: > + pmu->stop_txn(pmu);
If you let commit_txn() also clear the state you can save some logic and a method.
But yes, this looks good. If you don't remove the weak interface just yet, you can do a patch per architecture that uses this (at least powerpc and sparc do), and remove the weak thing at the end once all users are gone.
| |