lkml.org 
[lkml]   [2010]   [Apr]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [RFC] perf_events: support for uncore a.k.a. nest units
From
Date
On Wed, 2010-04-21 at 22:12 +0000, Lin Ming wrote:
> + ret = pmu->commit_txn(pmu);
> + if (!ret) {
> + pmu->stop_txn(pmu);
> + return 0;
> + }
>
> group_error:
> + pmu->stop_txn(pmu);

If you let commit_txn() also clear the state you can save some logic and
a method.

But yes, this looks good. If you don't remove the weak interface just
yet, you can do a patch per architecture that uses this (at least
powerpc and sparc do), and remove the weak thing at the end once all
users are gone.





\
 
 \ /
  Last update: 2010-04-21 16:25    [W:0.103 / U:0.340 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site