Messages in this thread |  | | From | David Howells <> | | Subject | Re: [PATCH 3/3] p9auth: add p9auth driver | | Date | Wed, 21 Apr 2010 11:49:15 +0100 |
| |
Serge E. Hallyn <serue@us.ibm.com> wrote:
> + if (ret == 0) > + commit_creds(new); > + else > + abort_creds(new); > + > + return ret;
If you make this:
if (ret == 0) return commit_creds(new); abort_creds(new); return ret;
then gcc can tail-call commit_creds(), which is guaranteed to return 0.
David
|  |