lkml.org 
[lkml]   [2010]   [Apr]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: repost - RFC [Patch] Remove "please try 'cgroup_disable=memory' option if you don't want memory cgroups" printk at boot time.
On Tue, 20 Apr 2010 10:26:27 -0400
Larry Woodman <lwoodman@redhat.com> wrote:

> Re-posting, cc'ing linux-mm as requested:
>
> We are considering removing this printk at boot time from RHEL because
> it will confuse customers, encourage them to change the boot parameters
> and generate extraneous support calls. Its documented in
> Documentation/kernel-parameters.txt anyway. Any thoughts???
>
> Larry Woodman
>
For RHEL, I agree removing the message makes sense.
But I'm unsure that small machine users, who never use memcg, can notice some
amount of memory are eaten at boot time.

Many distro tends to enable memcg by default and consume memory.

printk(KERN_INFO "allocated %ld bytes of page_cgroup\n", total_usage);
- printk(KERN_INFO "please try 'cgroup_disable=memory' option if you"
- " don't want memory cgroups\n");

Hmm.

printk(KERN_INFO "If you don't want page_cgroup,
you can disable this by boot option, cgroup_disable=memory".)

My biggest concern is that we don't have man(5) cgroup as other file systems.
If we have man(5), the best place for this kind of information will be it.
I think most of users will never see kernel-parameter.txt ..

If usual distros are shipped with man(5) cgroup, I agree removing
this in upstream.
(We have man pages for libcgroup but not man(5) for cgroup file system.)

I'm sorry if I don't notice that the latest man package has cgroup section.

Bye,
-Kame



\
 
 \ /
  Last update: 2010-04-21 02:31    [from the cache]
©2003-2011 Jasper Spaans