Messages in this thread | | | Date | Tue, 20 Apr 2010 19:18:04 +0200 (CEST) | From | Jiri Kosina <> | Subject | Re: [uml-devel] [PATCH 2/5] uml: Drop private round_down definition |
| |
On Tue, 20 Apr 2010, Jeff Dike wrote:
> > > Shouldn't this signal.c #include <linux/kernel.h>? > > > > Well, it gets included implicitly through uaccess.h -> sched.h -> > > kernel.h. > > You're depending on the internal details of uaccess.h and sched.h. If > either of them changed, then this would cause unexpected compile > failures here. > > Better to explicitly include kernel.h.
Yeah, I have that already in my tree.
Thanks,
-- Jiri Kosina SUSE Labs, Novell Inc.
| |