lkml.org 
[lkml]   [2010]   [Apr]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [uml-devel] [PATCH 2/5] uml: Drop private round_down definition
On Tue, 20 Apr 2010, Jeff Dike wrote:

> > > Shouldn't this signal.c #include <linux/kernel.h>?
> >
> > Well, it gets included implicitly through uaccess.h -> sched.h ->
> > kernel.h.
>
> You're depending on the internal details of uaccess.h and sched.h. If
> either of them changed, then this would cause unexpected compile
> failures here.
>
> Better to explicitly include kernel.h.

Yeah, I have that already in my tree.

Thanks,

--
Jiri Kosina
SUSE Labs, Novell Inc.


\
 
 \ /
  Last update: 2010-04-20 19:21    [W:3.187 / U:0.032 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site