lkml.org 
[lkml]   [2010]   [Apr]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [patch -mm] oom: exclude tasks with badness score of 0 from being selected
On 04/02, David Rientjes wrote:
>
> An oom_badness() score of 0 means "never kill" according to
> Documentation/filesystems/proc.txt, so explicitly exclude it from being
> selected for kill. These tasks have either detached their p->mm or are
> set to OOM_DISABLE.

Agreed, but

> @@ -336,6 +336,8 @@ static struct task_struct *select_bad_process(unsigned int *ppoints,
> continue;
>
> points = oom_badness(p, totalpages);
> + if (!points)
> + continue;
> if (points > *ppoints || !chosen) {

then "|| !chosen" can be killed.

with this patch !chosen <=> !*ppoints, and since points > 0

if (points > *ppoints) {

is enough.

Oleg.



\
 
 \ /
  Last update: 2010-04-02 23:09    [W:0.163 / U:0.404 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site