lkml.org 
[lkml]   [2010]   [Apr]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCHv3] drivers/net/usb: Add new driver ipheth
    On 04/02/2010 07:21 PM, Ben Hutchings wrote:
    > On Fri, 2010-04-02 at 19:15 +0200, "L. Alberto Giménez" wrote:
    >> On 04/01/2010 01:18 AM, Ben Hutchings wrote:
    >>> On Wed, 2010-03-31 at 21:42 +0200, L. Alberto Giménez wrote:
    >>> [...]
    >>>> --- /dev/null
    >>>> +++ b/drivers/net/usb/ipheth.c
    >>> [...]
    >>>> + usb_fill_bulk_urb(dev->tx_urb, udev,
    >>>> + usb_sndbulkpipe(udev, dev->bulk_out),
    >>>> + dev->tx_buf, IPHETH_BUF_SIZE,
    >>>> + ipheth_sndbulk_callback,
    >>>> + dev);
    >>>> + dev->tx_urb->transfer_flags |= URB_NO_TRANSFER_DMA_MAP;
    >>>> +
    >>>> + retval = usb_submit_urb(dev->tx_urb, GFP_ATOMIC);
    >>>> + if (retval) {
    >>>> + err("%s: usb_submit_urb: %d", __func__, retval);
    >>>> + dev->stats.tx_errors++;
    >>>> + dev_kfree_skb_irq(skb);
    >>>> + } else {
    >>>> + net->trans_start = jiffies;
    >>> No longer needed.
    >> What is not longer needed? The assignment, the whole "else" branch? If
    >> the assignment is what is not needed, can I just remove that line, right?
    >
    > The assignment is not needed.

    Hi,

    I've been looking into this and it seems that the net_device.trans_start
    field is now deprecated in favor of net_device.rx_queue.trans_start
    -rx_queue is a struct netdev_queue- (file include/linux/netdevice.h), as
    states the comment:

    512 /*
    513 * please use this field instead of dev->trans_start
    514 */
    515 unsigned long trans_start;

    Reading LDD3 book, it says that the driver is reponsible for updating
    trans_start (as well as trans_rx, but we're not talking about that one).

    So, I guess that the LDD book is outdated (again ;) ), but what I don't
    understand at all is wether the driver should keep updating the right
    field (dev->rx_queue.trans_start) or if the fact that it's inside a
    "queue" implies that the code that is responsible for that queue would
    update the trans_start field by itself?

    Thanks in advance.

    Best regards,
    --
    L. Alberto Giménez
    JabberID agimenez@jabber.sysvalve.es
    GnuPG key ID 0x3BAABDE1
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2010-04-02 19:57    [W:0.041 / U:59.908 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site