Messages in this thread | | | Date | Mon, 19 Apr 2010 20:11:54 +0200 | From | Ingo Molnar <> | Subject | Re: [PATCH V5 1/3] perf & kvm: Enhance perf to collect KVM guest os statistics from host side |
| |
FYI, i found a few problems that need fixing:
> + unsigned long ip; > + if (perf_guest_cbs && perf_guest_cbs->is_in_guest())
missing newline.
> + int misc = 0; > + if (perf_guest_cbs && perf_guest_cbs->is_in_guest()) {
ditto.
> + PERF_RECORD_MISC_GUEST_KERNEL; > + } else > + misc |= user_mode(regs) ? PERF_RECORD_MISC_USER : > + PERF_RECORD_MISC_KERNEL;
- unbalanced curly braces - missing curly brace for multi-line statement. - unnecessary line-break due to col80 warning from checkpatch
> +extern struct perf_guest_info_callbacks *perf_guest_cbs; > +extern int perf_register_guest_info_callbacks( > + struct perf_guest_info_callbacks *); > +extern int perf_unregister_guest_info_callbacks( > + struct perf_guest_info_callbacks *);
- unnecessary line-break due to col80 warning from checkpatch
> +static inline int perf_register_guest_info_callbacks > +(struct perf_guest_info_callbacks *) {return 0; } > +static inline int perf_unregister_guest_info_callbacks > +(struct perf_guest_info_callbacks *) {return 0; }
- invalid C: function parameter needs name even if unused - missing space after opening curly brace
Please provide delta fixes.
Ingo
| |