Messages in this thread | | | From | David Howells <> | Subject | RCU-isms in fs/nfs/delegation.c | Date | Mon, 19 Apr 2010 16:33:05 +0100 |
| |
I'm trying to redo my NFS RCU warning fixup patch on top of Paul's patches, and I've found a small potential bug: nfs_inode_reclaim_delegation() doesn't use the appropriate accessors/locks to protect NFS_I(inode)->delegation, and nor does it use such to protect *delegation that I can see. It just overwrites the record.
Furthermore, for consistency's sake, it should also protect accesses to delegation->cred within that function.
Trond: can you confirm that both NFS_I(inode)->delegation and delegation->cred should be considered RCU-protected pointers?
David
| |