| Subject | Re: [PATCH 13/35] fallthru: ext2 fallthru support | From | David Woodhouse <> | Date | Mon, 19 Apr 2010 14:02:48 +0100 |
| |
On Mon, 2010-04-19 at 14:40 +0200, Jan Blunck wrote: > On Thu, Apr 15, Valerie Aurora wrote: > > > Add support for fallthru directory entries to ext2. > > > > XXX - Makes up inode number for fallthru entry > > XXX - Might be better implemented as special symlinks > > Better not. David Woodhouse actually convinced me of moving away from the > special symlink approach. The whiteouts have been implemented as special > symlinks before.
I certainly asked whether you really need a real 'struct inode' for whiteouts, and suggested that they should be represented _purely_ as a dentry with type DT_WHT.
I don't much like the manifestation of that in this patch though, especially with the made-up inode number. (ISTR I had other jffs2-specific objections too, which I'll dig out and forward).
-- David Woodhouse Open Source Technology Centre David.Woodhouse@intel.com Intel Corporation
|