lkml.org 
[lkml]   [2010]   [Apr]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH] vmscan: page_check_references() check low order lumpy reclaim properly
    Date
    > > +       /*
    > > +        * If we need a large contiguous chunk of memory, or have
    > > +        * trouble getting a small set of contiguous pages, we
    > > +        * will reclaim both active and inactive pages.
    > > +        */
    > > +       if (sc->order > PAGE_ALLOC_COSTLY_ORDER)
    > > +               sc->lumpy_reclaim = 1;
    > > +       else if (sc->order && priority < DEF_PRIORITY - 2)
    > > +               sc->lumpy_reclaim = 1;
    > > +       else
    > > +               sc->lumpy_reclaim = 0;
    >
    > How about making new function for readability instead of nesting else?
    > int is_lumpy_reclaim(struct scan_control *sc)
    > {
    > ....
    > }
    >
    > If you merge patch reduced stack usage of reclaim path, I think it's
    > enough alone scan_control argument.
    > It's just nitpick. :)
    > If you don't mind, ignore, please.

    Good opinion. I don't hope introduce the dependency of "reduced stack usage"
    series. but I agree that I'll push your proposal later and separately.



    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2010-04-16 07:35    [W:0.021 / U:96.604 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site