Messages in this thread | | | Date | Fri, 16 Apr 2010 11:07:55 -0500 (CDT) | From | Christoph Lameter <> | Subject | Re: [PATCH 2/6] change alloc function in pcpu_alloc_pages |
| |
On Thu, 15 Apr 2010, Minchan Kim wrote:
> I don't want to remove alloc_pages for UMA system.
alloc_pages is the same as alloc_pages_any_node so why have it?
> #define alloc_pages alloc_page_sexact_node > > What I want to remove is just alloc_pages_node. :)
Why remove it? If you want to get rid of -1 handling then check all the callsites and make sure that they are not using -1.
Also could you define a constant for -1? -1 may have various meanings. One is the local node and the other is any node. The difference is if memory policies are obeyed or not. Note that alloc_pages follows memory policies whereas alloc_pages_node does not.
Therefore
alloc_pages() != alloc_pages_node( , -1)
| |