Messages in this thread | | | Date | Thu, 15 Apr 2010 14:54:46 -0300 | From | Marcelo Tosatti <> | Subject | Re: [PATCH v2 2/5] KVM MMU: fix kvm_mmu_zap_page() and its calling path |
| |
On Fri, Apr 16, 2010 at 09:25:03PM +0800, Xiao Guangrong wrote: > - calculate zapped page number properly in mmu_zap_unsync_children() > - calculate freeed page number properly kvm_mmu_change_mmu_pages() > > Signed-off-by: Xiao Guangrong <xiaoguangrong@cn.fujitsu.com> > --- > arch/x86/kvm/mmu.c | 12 ++++++++---- > 1 files changed, 8 insertions(+), 4 deletions(-) > > diff --git a/arch/x86/kvm/mmu.c b/arch/x86/kvm/mmu.c > index a23ca75..41cccd4 100644 > --- a/arch/x86/kvm/mmu.c > +++ b/arch/x86/kvm/mmu.c > @@ -1481,13 +1481,16 @@ static int mmu_zap_unsync_children(struct kvm *kvm, > struct kvm_mmu_page *sp; > > for_each_sp(pages, sp, parents, i) { > + if (list_empty(&kvm->arch.active_mmu_pages)) > + goto exit;
I meant to check for list_empty in kvm_mmu_change_mmu_pages, instead of relying on the count returned by kvm_mmu_zap_page. Similarly to what __kvm_mmu_free_some_pages does.
Checking here is not needed because the pages returned in the array will not be zapped (mmu_lock is held).
Applied 1, 4 and 5 (so please regenerate against kvm.git -next branch), thanks.
| |