Messages in this thread | | | From | Fabio Giovagnini <> | Subject | Re: [PATCH 1/2] MTD: cfi_cmdset_0002: Add reboot notifier for AMD flashes | Date | Wed, 14 Apr 2010 07:33:12 +0200 |
| |
Exactly!!!! Why this is requested? Is it necessary for the best proper woring mode?
Thanks a lot
In data mercoledì 14 aprile 2010 06:57:58, Artem Bityutskiy ha scritto: : > On Tue, 2010-04-13 at 13:30 -0700, Kevin Cernekee wrote: > > +static int cfi_amdstd_reset(struct mtd_info *mtd) > > +{ > > + struct map_info *map = mtd->priv; > > + struct cfi_private *cfi = map->fldrv_priv; > > + int i, ret; > > + struct flchip *chip; > > + > > + for (i = 0; i < cfi->numchips; i++) { > > + > > + chip = &cfi->chips[i]; > > + > > + spin_lock(chip->mutex); > > + > > + ret = get_chip(map, chip, chip->start, FL_SHUTDOWN); > > + if (!ret) { > > + map_write(map, CMD(0xF0), chip->start); > > + chip->state = FL_SHUTDOWN; > > + put_chip(map, chip, chip->start); > > + } > > + > > + spin_unlock(chip->mutex); > > + } > > + > > + return 0; > > +} > > Kevin, I'd suggest to document why you do this in the code, just for the > next generation, or for the archaeologists who will dig MTD code in the > future. >
-- Fabio Giovagnini
Aurion s.r.l. P.I e C.F. 00885711200 Tel. +39.051.594.78.24 Cell. +39.335.83.50.919 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |