Messages in this thread | | | Date | Wed, 14 Apr 2010 09:33:22 +0900 | Subject | Re: [PATCH 5/6] change alloc function in __vmalloc_area_node | From | Minchan Kim <> |
| |
On Wed, Apr 14, 2010 at 9:22 AM, KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com> wrote: > On Wed, 14 Apr 2010 00:25:02 +0900 > Minchan Kim <minchan.kim@gmail.com> wrote: > >> __vmalloc_area_node never pass -1 to alloc_pages_node. >> It means node's validity check is unnecessary. >> So we can use alloc_pages_exact_node instead of alloc_pages_node. >> It could avoid comparison and branch as 6484eb3e2a81807722 tried. >> >> Cc: Nick Piggin <npiggin@suse.de> >> Signed-off-by: Minchan Kim <minchan.kim@gmail.com> > > Reviewed-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com> > > But, in another thinking, > > - if (node < 0) > - page = alloc_page(gfp_mask); > > may be better ;)
I thought it. but alloc_page is different function with alloc_pages_node in NUMA. It calls alloc_pages_current.
-- Kind regards, Minchan Kim -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |