Messages in this thread | | | Date | Tue, 13 Apr 2010 14:37:52 -0700 (PDT) | From | David Rientjes <> | Subject | Re: [PATCH 3/6] change alloc function in alloc_slab_page |
| |
On Wed, 14 Apr 2010, Minchan Kim wrote:
> alloc_slab_page never calls alloc_pages_node with -1. > It means node's validity check is unnecessary. > So we can use alloc_pages_exact_node instead of alloc_pages_node. > It could avoid comparison and branch as 6484eb3e2a81807722 tried. > > Cc: Christoph Lameter <cl@linux-foundation.org> > Signed-off-by: Minchan Kim <minchan.kim@gmail.com> > --- > mm/slub.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/mm/slub.c b/mm/slub.c > index b364844..9984165 100644 > --- a/mm/slub.c > +++ b/mm/slub.c > @@ -1084,7 +1084,7 @@ static inline struct page *alloc_slab_page(gfp_t flags, int node, > if (node == -1) > return alloc_pages(flags, order); > else > - return alloc_pages_node(node, flags, order); > + return alloc_pages_exact_node(node, flags, order); > } > > static struct page *allocate_slab(struct kmem_cache *s, gfp_t flags, int node)
Slub changes need to go through its maintainer, Pekka Enberg <penberg@cs.helsinki.fi>.
| |