lkml.org 
[lkml]   [2010]   [Apr]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/3 ] SCSI: Support several features in arcmsr driver
On Fri, 9 Apr 2010 10:24:19 +0800
"Nick Cheng" <nick.cheng@areca.com.tw> wrote:

> 1. To support instantaneous report for SCSI device existing by periodic
> polling
> 2. In arcmsr_iop_xfer(), inform AP of F/W's deadlock state to prevent
> endless waiting
> 3. To block the coming SCSI command while the driver is handling bus reset
> 4. To support HW reset in bus reset error handler
> Signed-off-by: Nick Cheng< nick.cheng@areca.com.tw >
>
>
> [patch1 application/octet-stream (39.7KB)]

Lots of problems here.

- Two of the patches had the same title ("SCSI: Support several
features in arcmsr driver"). Please ensure that each patch has a
unique and well-chosen title.

- application/octet-stream attachments are hard for people to read
in-line in mail clients. Please at least use text/plain MIME type if
possible.

- The patches aren't in `patch -p1' form. You had

--- arcmsr/arcmsr_attr.c
+++ arcmsr.1.20.00.15-81103/arcmsr_attr.c

which cannot be applied from the top-level of the kernel tree. It
should have been

--- a/drivers/scsi/arcmsr/arcmsr_attr.c
+++ a/drivers/scsi/arcmsr/arcmsr_attr.c

or similar.

I got all that fixed up, but when applying the second patch (using
2.6.34-rc4) I encountered a large number of patch rejects and gave up.

So please fix all that up and resend. Perhaps you could use
http://savannah.nongnu.org/projects/quilt which automates all this.

Also, please run scripts/checkpatch.pl across the patches - it reports
rather a lot of minor issues which you might choose to address.

Thanks.


\
 
 \ /
  Last update: 2010-04-13 22:13    [W:0.147 / U:0.016 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site