lkml.org 
[lkml]   [2010]   [Apr]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/4] blkdev: pass gfp_mask and flags to blkdev_issue_flush
On Mon, Apr 12, 2010 at 05:03:54PM +0400, Dmitry Monakhov wrote:
> In some places caller don't want to wait a request to complete.
> Flags make blkdev_issue_flush() more flexible. This patch just
> convert existing callers to new interface without chaining
> existing allocation/wait behavior.

Looks okay to me, but as mention in the other review I would introduce
the comment flags first and then add the flags to blkdev_issue_flush,
not the other way around.



\
 
 \ /
  Last update: 2010-04-13 20:11    [W:0.134 / U:25.864 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site