Messages in this thread | | | Date | Tue, 13 Apr 2010 14:08:36 -0400 | From | Christoph Hellwig <> | Subject | Re: [PATCH 1/4] blkdev: pass gfp_mask and flags to blkdev_issue_flush |
| |
On Mon, Apr 12, 2010 at 05:03:54PM +0400, Dmitry Monakhov wrote: > In some places caller don't want to wait a request to complete. > Flags make blkdev_issue_flush() more flexible. This patch just > convert existing callers to new interface without chaining > existing allocation/wait behavior.
Looks okay to me, but as mention in the other review I would introduce the comment flags first and then add the flags to blkdev_issue_flush, not the other way around.
| |