lkml.org 
[lkml]   [2010]   [Apr]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH 3/6] change alloc function in alloc_slab_page
    From
    On Wed, Apr 14, 2010 at 12:52 AM, Mel Gorman <mel@csn.ul.ie> wrote:
    > On Wed, Apr 14, 2010 at 12:25:00AM +0900, Minchan Kim wrote:
    >> alloc_slab_page never calls alloc_pages_node with -1.
    >
    > Are you certain? What about
    >
    > __kmalloc
    >  -> slab_alloc (passed -1 as a node from __kmalloc)
    >    -> __slab_alloc
    >      -> new_slab
    >        -> allocate_slab
    >          -> alloc_slab_page
    >

    Sorry for writing confusing changelog.

    I means if node == -1 alloc_slab_page always calls alloc_pages.
    So we don't need redundant check.

    --
    Kind regards,
    Minchan Kim
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2010-04-13 18:03    [W:0.030 / U:119.016 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site