lkml.org 
[lkml]   [2010]   [Apr]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRE: [PATCH v3 3/6] RapidIO: Add Port-Write handling for EM
Date
From
Andrew Morton wrote:
> On Tue, 6 Apr 2010 17:22:38 -0400 Alexandre Bounine
<abounine@tundra.com> wrote:
>
> >
> > From: Alexandre Bounine <alexandre.bounine@idt.com>
> >
> > Add RapidIO Port-Write message handling in the context
> > of Error Management Extensions Specification Rev.1.3.
> >
> > ...
> >
> > +static struct rio_dev *rio_get_comptag(u32 comp_tag, struct rio_dev
*from)
> > +{
> > + struct list_head *n;
> > + struct rio_dev *rdev;
> > +
> > + WARN_ON(in_interrupt());
>
> The check should be unneeded - lockdep will warn about this.

Thank you. I will remove it in my next set of patches.

>
> > + spin_lock(&rio_global_list_lock);
> > + n = from ? from->global_list.next : rio_devices.next;
> > +
> > + while (n && (n != &rio_devices)) {
> > + rdev = rio_dev_g(n);
> > + if (rdev->comp_tag == comp_tag)
> > + goto exit;
> > + n = n->next;
> > + }
> > + rdev = NULL;
> > +exit:
> > + spin_unlock(&rio_global_list_lock);
> > + return rdev;
> > +}
> > +



\
 
 \ /
  Last update: 2010-04-13 17:21    [W:0.033 / U:0.064 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site