Messages in this thread | | | Date | Mon, 12 Apr 2010 16:55:08 +0800 | From | Xiao Guangrong <> | Subject | Re: [PATCH 3/6] KVM MMU: optimize/cleanup for marking parent unsync |
| |
Avi Kivity wrote: > On 04/12/2010 11:02 AM, Xiao Guangrong wrote: >> - 'vcpu' is not used while mark parent unsync, so remove it >> - if it has alread marked unsync, no need to walk it's parent >> >> > > Please separate these two changes. > > The optimization looks good. Perhaps it can be done even nicer using > mutually recursive functions (mmu_parent_walk calls mmu_parent_walk_fn > which calls mmu_parent_walk on the parent), but let's not change too > many things at a time.
OK, i'll separate it in the next version
Thanks, Xiao
| |