Messages in this thread | | | From | Arnd Bergmann <> | Subject | Re: [GIT, RFC] Killing the Big Kernel Lock | Date | Thu, 1 Apr 2010 10:50:42 +0200 |
| |
On Thursday 01 April 2010, Roland Dreier wrote: > Looking at your tree, I see you have commit 753dd249 ("perf_event: use > nonseekable_open") that does: > > > --- a/kernel/perf_event.c > > +++ b/kernel/perf_event.c > > @@ -2515,6 +2515,8 @@ static int perf_fasync(int fd, struct file *filp, int on) > > } > > > > static const struct file_operations perf_fops = { > > + .open = nonseekable_open, > > + .llseek = no_llseek, > > .release = perf_release, > > .read = perf_read, > > .poll = perf_poll, > > But if I understand this correctly, the assignment to .open is at best > useless -- these file_operations are only used via anon_inode_getfd() > and so there is no possible path that can call the .open method. Or am > I missing something?
You're right. I did not consider this.
Arnd
| |