lkml.org 
[lkml]   [2010]   [Apr]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [GIT, RFC] Killing the Big Kernel Lock
    Date
    On Thursday 01 April 2010, Roland Dreier wrote:
    > Looking at your tree, I see you have commit 753dd249 ("perf_event: use
    > nonseekable_open") that does:
    >
    > > --- a/kernel/perf_event.c
    > > +++ b/kernel/perf_event.c
    > > @@ -2515,6 +2515,8 @@ static int perf_fasync(int fd, struct file *filp, int on)
    > > }
    > >
    > > static const struct file_operations perf_fops = {
    > > + .open = nonseekable_open,
    > > + .llseek = no_llseek,
    > > .release = perf_release,
    > > .read = perf_read,
    > > .poll = perf_poll,
    >
    > But if I understand this correctly, the assignment to .open is at best
    > useless -- these file_operations are only used via anon_inode_getfd()
    > and so there is no possible path that can call the .open method. Or am
    > I missing something?

    You're right. I did not consider this.

    Arnd


    \
     
     \ /
      Last update: 2010-04-01 10:53    [W:0.034 / U:0.316 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site