Messages in this thread | | | Date | Thu, 01 Apr 2010 15:24:05 +0800 | From | Lai Jiangshan <> | Subject | Re: [PATCH] rcu: don't call rcu_preempt_note_context_switch() in rcu_check_callbacks() |
| |
Paul E. McKenney wrote: > Possibly by moving the clearing of RCU_READ_UNLOCK_NEED_QS to > rcu_preempt_check_callbacks()
current rcu_preempt_check_callbacks() already has code to clear RCU_READ_UNLOCK_NEED_QS.
> -- or to rcu_preempt_qs(). The latter is in > some sense cleaner, but higher overhead and probably unnecessary. Hmmm... > Alternatively, require that all callers to rcu_preempt_qs() disable > irqs. This affects only one callsite, which has a local_irq_disable() > immediately following anyway. ;-) > > Thanx, Paul
| |