Messages in this thread | | | From | Andres Salomon <> | Subject | Re: [PATCH] printk.c: remove duplicate const | Date | Thu, 1 Apr 2010 22:02:40 -0400 |
| |
On Thu, 01 Apr 2010 18:20:04 -0700 (PDT) David Miller <davem@davemloft.net> wrote:
> From: H Hartley Sweeten <hartleys@visionengravers.com> > Date: Thu, 1 Apr 2010 20:13:27 -0500 > > > Noticed during a sparse build. > > > > Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com> > > Isn't it intentional? The two consts mark different aspects > of the declaration const, both the pointers as well as the > contents pointed to.
I believe that'd be -
static const char *const kmsg_reasons[]
rather than what was originally in the code -
static const char const *kmsg_reasons[]
Read right-to-left, the first is a constant pointer to a char constant; the second is a pointer to a constant character constant. I suspect the first is what was intended.
| |