lkml.org 
[lkml]   [2010]   [Apr]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/2] x86/amd-iommu: enable iommu before attaching devices
* Neil Horman (nhorman@redhat.com) wrote:
> On Thu, Apr 01, 2010 at 06:23:53PM -0700, Chris Wright wrote:
> > Hit another kdump problem as reported by Neil Horman. When initializaing
> > the IOMMU, we attach devices to their domains before the IOMMU is
> > fully (re)initialized. Attaching a device will issue some important
> > invalidations. In the context of the newly kexec'd kdump kernel, the
> > IOMMU may have stale cached data from the original kernel. Because we
> > do the attach too early, the invalidation commands are placed in the new
> > command buffer before the IOMMU is updated w/ that buffer. This leaves
> > the stale entries in the kdump context and can renders device unusable.
> > Simply enable the IOMMU before we do the attach.
> >
> > Cc: Neil Horman <nhorman@tuxdriver.com>
> > Cc: Vivek Goyal <vgoyal@redhat.com>
> > Signed-off-by: Chris Wright <chrisw@sous-sol.org>
>
> I'll test this out this weekend, thanks Chris!

Great, thanks! I tested w/ both default and iommu=pt. Both worked,
didn't spot any regressions. But additional testing is very welcome.

thanks,
-chris


\
 
 \ /
  Last update: 2010-04-02 03:41    [W:0.176 / U:1.236 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site