Messages in this thread | | | Date | Thu, 01 Apr 2010 17:26:35 -0700 (PDT) | Subject | Re: [Patch V3] bonding: fix potential deadlock in bond_uninit() | From | David Miller <> |
| |
From: Cong Wang <amwang@redhat.com> Date: Thu, 01 Apr 2010 15:30:52 +0800
> Eric W. Biederman wrote: >> Amerigo Wang <amwang@redhat.com> writes: >> >>> bond_uninit() is invoked with rtnl_lock held, when it does >>> destroy_workqueue() >>> which will potentially flush all works in this workqueue, if we hold >>> rtnl_lock >>> again in the work function, it will deadlock. >>> >>> So move destroy_workqueue() to destructor where rtnl_lock is not held >>> any more, >>> suggested by Eric. >> The error handling on creating a bond device needs to be updated as >> well. >> > > Done.
Applied, thanks.
| |