lkml.org 
[lkml]   [2010]   [Apr]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [Patch V3] bonding: fix potential deadlock in bond_uninit()
    From
    From: Cong Wang <amwang@redhat.com>
    Date: Thu, 01 Apr 2010 15:30:52 +0800

    > Eric W. Biederman wrote:
    >> Amerigo Wang <amwang@redhat.com> writes:
    >>
    >>> bond_uninit() is invoked with rtnl_lock held, when it does
    >>> destroy_workqueue()
    >>> which will potentially flush all works in this workqueue, if we hold
    >>> rtnl_lock
    >>> again in the work function, it will deadlock.
    >>>
    >>> So move destroy_workqueue() to destructor where rtnl_lock is not held
    >>> any more,
    >>> suggested by Eric.
    >> The error handling on creating a bond device needs to be updated as
    >> well.
    >>
    >
    > Done.

    Applied, thanks.


    \
     
     \ /
      Last update: 2010-04-02 02:29    [W:2.754 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site