lkml.org 
[lkml]   [2010]   [Apr]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/1] oom: fix the unsafe usage of badness() in proc_oom_score()
On Thu, 1 Apr 2010, Oleg Nesterov wrote:

> proc_oom_score(task) have a reference to task_struct, but that is all.
> If this task was already released before we take tasklist_lock
>
> - we can't use task->group_leader, it points to nowhere
>
> - it is not safe to call badness() even if this task is
> ->group_leader, has_intersects_mems_allowed() assumes
> it is safe to iterate over ->thread_group list.
>
> - even worse, badness() can hit ->signal == NULL
>
> Add the pid_alive() check to ensure __unhash_process() was not called.
>
> Also, use "task" instead of task->group_leader. badness() should return
> the same result for any sub-thread. Currently this is not true, but
> this should be changed anyway.
>
> Signed-off-by: Oleg Nesterov <oleg@redhat.com>

Acked-by: David Rientjes <rientjes@google.com>

Andrew, this is 2.6.34 material and should be backported to stable. It's
not introduced by the recent oom killer rewrite pending in -mm, but it
will require a trivial merge resolution on that work.


\
 
 \ /
  Last update: 2010-04-01 21:07    [W:0.233 / U:0.408 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site